linux-kernel - Re: [GIT PULL] x86/asm for 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikrCBdK6e75aZSv8AvKE31DdJnE53hGXR=uN9TE@mail.gmail.com>
Date:	Fri, 6 Aug 2010 10:56:00 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>, stable@...nel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Avi Kivity <avi@...hat.com>, Brian Gerst <brgerst@...il.com>,
	Glauber Costa <glommer@...hat.com>, Greg KH <gregkh@...e.de>,
	Ingo Molnar <mingo@...e.hu>, Jeff Dike <jdike@...toit.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Peter Palfrader <peter@...frader.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Zachary Amsden <zamsden@...hat.com>
Subject: Re: [GIT PULL] x86/asm for 2.6.36

On Fri, Aug 6, 2010 at 10:45 AM, H. Peter Anvin <hpa@...or.com> wrote:
>
> It's worth noting that in this particular case the code itself looks
> like this:
>
>        set_64bit((unsigned long *)&irte->low, irte_modified->low);
>        set_64bit((unsigned long *)&irte->high, irte_modified->high);
>
> ... where the existing cast is there because irte->low and irte->high
> are types __u64.  In other words, with the "more logical" u64 prototype
> the casts should just get removed.

Ok, right you are. I'll just remove the casts, since that makes the
code look better. Maybe it will cause warnings on some other plaform,
but I do agree that maybe the right thing to do is to just say
"set_64bit() should have taken a u64 * to begin with".

> On the other hand I should have seen this sooner, obviously.

Yeah, I didn't look at the code, I just reacted to "hmm, this results
in new warnings, not good".

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/