linux-kernel - Re: [GIT PULL] x86/asm for 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C5C4E7A.8040603@kernel.org>
Date:	Fri, 06 Aug 2010 11:03:38 -0700
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	"H. Peter Anvin" <hpa@...ux.intel.com>, stable@...nel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Avi Kivity <avi@...hat.com>, Brian Gerst <brgerst@...il.com>,
	Glauber Costa <glommer@...hat.com>, Greg KH <gregkh@...e.de>,
	Ingo Molnar <mingo@...e.hu>, Jeff Dike <jdike@...toit.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Peter Palfrader <peter@...frader.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Zachary Amsden <zamsden@...hat.com>
Subject: Re: [GIT PULL] x86/asm for 2.6.36

On 08/06/2010 10:45 AM, H. Peter Anvin wrote:
> 
> It's worth noting that in this particular case the code itself looks
> like this:
> 
> 	set_64bit((unsigned long *)&irte->low, irte_modified->low);
> 	set_64bit((unsigned long *)&irte->high, irte_modified->high);
> 
> ... where the existing cast is there because irte->low and irte->high
> are types __u64.  In other words, with the "more logical" u64 prototype
> the casts should just get removed.
> 

Looking through the build I'm currently running, so far, it is smoking
out a bunch of unnecessary casts and wrappers, for example, in kvm/mmu.c:

static void __set_spte(u64 *sptep, u64 spte)
{
#ifdef CONFIG_X86_64
	set_64bit((unsigned long *)sptep, spte);
#else
	set_64bit((unsigned long long *)sptep, spte);
#endif
}

... which just becomes the much cleaner ...

static void __set_spte(u64 *sptep, u64 spte)
{
	set_64bit(sptep, spte);
}

I'll go through all these as this build finishes and give you an updated
tree to pull, ok?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/