[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <9D74DA20-E3C8-43BC-B529-82605F64637F@crocodile.org>
Date: Sun, 8 Aug 2010 18:24:39 -0700
From: Vadim Zaliva <lord@...codile.org>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Johannes Berg <johannes@...solutions.net>,
Serge Belyshev <belyshev@...ni.sinp.msu.ru>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver
I have tested the patch on device I had
I will have an access to it to retest later thus week. We can wait for my test to try to identify how my PowerBook is different from yours. Or you can roll the patch back.
--
Sent from my iPhone
On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
>
>>> My device is 05ac:020e "fountain", actually generates *signed* values,
>>> thus the patch completely breaks it.
>>
>> I think Ben might have the same issue. I guess we need per-touchpad
>> functions to read the data.
>
> Yup, I confirm, same deal. This patch completely breaks it on my
> powerbook (same USB ID)
>
> Should we revert the commit for now ?
>
> Cheers,
> Ben.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists