linux-kernel - Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1281325390.2168.64.camel@pasglop>
Date:	Mon, 09 Aug 2010 13:43:09 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Vadim Zaliva <lord@...codile.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Serge Belyshev <belyshev@...ni.sinp.msu.ru>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver

On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> I have tested the patch on device I had       
> I will have an access to it to retest later thus week. We can wait for my
> test to try to identify how my PowerBook is different from yours. Or you
> can roll the patch back.

I'd rather roll the patch back for now. I'll send the revert as part of
the next powerpc update. We'll sort things out then.

Cheers,
Ben.

> 
> --
> Sent from my iPhone
> 
> On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> 
> > 
> >>> My device is 05ac:020e "fountain", actually generates *signed* values,
> >>> thus the patch completely breaks it.
> >> 
> >> I think Ben might have the same issue. I guess we need per-touchpad
> >> functions to read the data.
> > 
> > Yup, I confirm, same deal. This patch completely breaks it on my
> > powerbook (same USB ID)
> > 
> > Should we revert the commit for now ?
> > 
> > Cheers,
> > Ben.
> > 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/