linux-kernel - Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5FCF0C.2000100@gmail.com>
Date:	Mon, 09 Aug 2010 11:49:00 +0200
From:	Tejun Heo <htejun@...il.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
CC:	Heiko Carstens <heiko.carstens@...ibm.com>,
	walt <w41ter@...il.com>, linux-kernel@...r.kernel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should
 be cpu_notifier not hotcpu_notifier

Hello,

On 08/09/2010 11:46 AM, Markus Trippelsdorf wrote:
> This fixes the boot problem here. Thanks.

Great.  May I add your Tested-by?

> (The drm delayed enqueue problem, which I mentioned earlier still
> persists.)

Yeah, I'm looking into it now but it looks like the error message is
simply spurious.  queue_delayed_work() returns 1 if the work was
actually queued and 0 if it was already pending and thus the function
call was no-op.  output_poll_execute() is incorrectly interpreting 1
return as error.  I'll look through the history and try to find out
whether/how wq changes affected the behavior, but the fix is most
likely simply killing the message.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/