linux-kernel - Re: [PATCHv7 7/8] usb: gadget: storage: remove nofua file when unbinding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinyPBp4HtWuxM=kSbe6nL2WP65B3tq-nCyMKJov@mail.gmail.com>
Date:	Thu, 12 Aug 2010 14:32:23 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
Cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	USB <linux-usb@...r.kernel.org>, linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	Denis Karpov <ext-denis.2.karpov@...ia.com>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
Subject: Re: [PATCHv7 7/8] usb: gadget: storage: remove nofua file when unbinding

On Mon, Aug 9, 2010 at 6:02 PM, Michal Nazarewicz
<m.nazarewicz@...sung.com> wrote:
> The dev_attr_nofua file was created during fsg_bind() but
> was never removed.  Made it a bit more symmetrical and added
> code to remove the file in fsg_unbind().
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@...sung.com>
> Cc: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
> ---
>  drivers/usb/gadget/file_storage.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c
> index a857b7a..ab77792 100644
> --- a/drivers/usb/gadget/file_storage.c
> +++ b/drivers/usb/gadget/file_storage.c
> @@ -3178,6 +3178,7 @@ static void /* __init_or_exit */ fsg_unbind(struct usb_gadget *gadget)
>        for (i = 0; i < fsg->nluns; ++i) {
>                curlun = &fsg->luns[i];
>                if (curlun->registered) {
> +                       device_remove_file(&curlun->dev, &dev_attr_nofua);
>                        device_remove_file(&curlun->dev, &dev_attr_ro);
>                        device_remove_file(&curlun->dev, &dev_attr_file);
>                        fsg_lun_close(curlun);
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Acked-by: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/