linux-kernel - Re: [PATCHv7 8/8] usb: gadget: mass_storage: optional SCSI WRITE FUA bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=RBuXMgAohF1=1eNwZh791Q0CgX60CHUsBrBTK@mail.gmail.com>
Date:	Thu, 12 Aug 2010 14:33:41 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
Cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	USB <linux-usb@...r.kernel.org>, linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	Denis Karpov <ext-denis.2.karpov@...ia.com>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
Subject: Re: [PATCHv7 8/8] usb: gadget: mass_storage: optional SCSI WRITE FUA bit

On Mon, Aug 9, 2010 at 6:02 PM, Michal Nazarewicz
<m.nazarewicz@...sung.com> wrote:
> The nofua parameter (optionally ignore SCSI WRITE FUA) was added
> to the File Storage Gadget some time ago.  This patch adds the
> same functionality to the Mass Storage Function.
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@...sung.com>
> Cc: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
> +               rc = device_create_file(&curlun->dev, &dev_attr_nofua);
> +               if (rc)
> +                       goto error_luns;
It has the same issue as my original patch - forgot to remove device node.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/