linux-kernel - Re: [patch] usb/serial/ssu100: uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100813125824.87BC52389B@viridian.itc.virginia.edu>
Date:	Fri, 13 Aug 2010 08:58:24 -0400 (EDT)
From:	wfp5p@...idian.itc.virginia.edu (Bill Pemberton)
To:	error27@...il.com (Dan Carpenter)
Cc:	gregkh@...e.de (Greg Kroah-Hartman), linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] usb/serial/ssu100: uninitialized variable

> 
> GCC complains about the original code, because we're using an
> unintialized variable "flag".  I think we should be setting flag based
> on the UART_LSR_BRK_ERROR_BITS but I'm not sure...  I don't have this
> hardware.  Probably passing TTY_NORMAL is better than the current code?
> 

I took that function from ftdi_sio and stripped a lot out of it
while developing the driver.  I see I missed adding back in the logic
dealing with setting flag correctly.  I'll work up a patch to properly
deal with it.

-- 
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/