linux-kernel - Re: [PATCH] microblaze: Fix of/address: Merge all of the bus translation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=ftyRxcxzerRjNPQyqeGjxW++BYk1UK7ajtjJo@mail.gmail.com>
Date:	Mon, 16 Aug 2010 14:33:38 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Michal Simek <monstr@...str.eu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] microblaze: Fix of/address: Merge all of the bus
 translation code

Hi Michal,

Looks good, I'll pick it up.  Same of the of_node patch.

On Mon, Aug 16, 2010 at 2:31 AM, Michal Simek <monstr@...str.eu> wrote:
> Commit dbbdee94734bf6f1db7af42008a53655e77cab8f removed
> of_irq_pci_swizzle but didn't use pci_swizzle_interrupt_pin
> instead.

Note: when writing commit messages, be friendly to readers who don't
immediately have access to a git tree.  It is good to quote the sha1
id, but you should also quote the patch title like so:

Commit "of/address: Merge all of the bus translation code" (sha1 id:
dbbdee94734bf6f1db7af42008a53655e77cab8f) removed of_irq_pci_swizzle
but didn't use pci_swizzle_interrupt_pin instead.

No need to respin this patch, I'll fix it up.  just a comment for next time.

Cheers,
g.

> ---
>  arch/microblaze/kernel/prom_parse.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/microblaze/kernel/prom_parse.c b/arch/microblaze/kernel/prom_parse.c
> index d33ba17..99d9b61 100644
> --- a/arch/microblaze/kernel/prom_parse.c
> +++ b/arch/microblaze/kernel/prom_parse.c
> @@ -73,7 +73,7 @@ int of_irq_map_pci(struct pci_dev *pdev, struct of_irq *out_irq)
>                /* We can only get here if we hit a P2P bridge with no node,
>                 * let's do standard swizzling and try again
>                 */
> -               lspec = of_irq_pci_swizzle(PCI_SLOT(pdev->devfn), lspec);
> +               lspec = pci_swizzle_interrupt_pin(pdev, lspec);
>                pdev = ppdev;
>        }
>
> --
> 1.5.5.6
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/