[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTimLqc02xNun0QR5ZgP497mm8ZC5ZfpCUx2AGz4Y@mail.gmail.com>
Date: Tue, 17 Aug 2010 14:47:05 -0700
From: Michel Lespinasse <walken@...gle.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Tony Luck <tony.luck@...el.com>,
David Miller <davem@...emloft.net>,
David Howells <dhowells@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: tasks getting stuck on mmap_sem?
On Tue, Aug 17, 2010 at 2:28 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> Oh, and it strikes me when looking at the sparc rwsem-const.h that it
> has some unsigned constants in it. I think
>
> #define RWSEM_WAITING_BIAS 0xffff0000
>
> is actually unsigned, because it's a hex constant that doesn't fit in
> a signed int. So it's of type 'unsigned int' if I recall the C type
> rules right.
Eeeek, this totally escaped me when I had a quick look at constant
signed-ness across architectures. This is definitely a problem.
> #define RWSEM_WAITING_BIAS (-0x00010000)
David, do you still see failures with v2.6.36-rc1 plus that one line fix ?
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists