[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100817.145908.112609486.davem@davemloft.net>
Date: Tue, 17 Aug 2010 14:59:08 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: walken@...gle.com
Cc: torvalds@...ux-foundation.org, tony.luck@...el.com,
dhowells@...hat.com, akpm@...ux-foundation.org,
linux-kernel@...r.kernel.org
Subject: Re: tasks getting stuck on mmap_sem?
From: Michel Lespinasse <walken@...gle.com>
Date: Tue, 17 Aug 2010 14:47:05 -0700
> On Tue, Aug 17, 2010 at 2:28 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>> Oh, and it strikes me when looking at the sparc rwsem-const.h that it
>> has some unsigned constants in it. I think
>>
>> #define RWSEM_WAITING_BIAS 0xffff0000
>>
>> is actually unsigned, because it's a hex constant that doesn't fit in
>> a signed int. So it's of type 'unsigned int' if I recall the C type
>> rules right.
>
> Eeeek, this totally escaped me when I had a quick look at constant
> signed-ness across architectures. This is definitely a problem.
>
>> #define RWSEM_WAITING_BIAS (-0x00010000)
>
> David, do you still see failures with v2.6.36-rc1 plus that one line fix ?
As I said in a reply to Tony I don't even think your commit is
to blame, because even after reverting it I still have the
problems.
I'll keep digging into this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists