linux-kernel - RE: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <496565EC904933469F292DDA3F1663E602CA4D894C@dlee06.ent.ti.com>
Date:	Mon, 16 Aug 2010 23:48:14 -0500
From:	"Guzman Lugo, Fernando" <fernando.lugo@...com>
To:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"Kanigeri, Hari" <h-kanigeri2@...com>,
	"Hiroshi.DOYU@...ia.com" <Hiroshi.DOYU@...ia.com>
Subject: RE: [PATCH] iommu: fix end address of vm area comparation in
 alloc_iovm_area

There was a mistake with Hiroshi email. Looping in Hiroshi

Sorry for the noise.

Regards,
Fernando.
________________________________________
From: linux-omap-owner@...r.kernel.org [linux-omap-owner@...r.kernel.org] On Behalf Of Guzman Lugo, Fernando [fernando.lugo@...com]
Sent: Monday, August 16, 2010 10:51 PM
To: linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org
Cc: Hiroshi.DOYO@...ia.com; Kanigeri, Hari
Subject: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm_area

>From cc48c0adaee97c8385a356aefa5b64a51818b4fd Mon Sep 17 00:00:00 2001
From: Fernando Guzman Lugo <x0095840@...com>
Date: Mon, 16 Aug 2010 22:28:24 -0500
Subject: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm_area

End address of the vm area is “start + bytes -1”,
not “start + byte”. This patch fixes that issue by doing
an inclusive comparison with tmp->da_start. This issue
was preventing allocate an area of size exactly the same
than the free area. I did no change the value of da_end
of each vm area because it is used to get area size in
several places.

Signed-off-by: Fernando Guzman Lugo <x0095840@...com>
---
 arch/arm/plat-omap/iovmm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index b8bcad5..8745d4e 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -295,7 +295,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
        prev_end = 0;
        list_for_each_entry(tmp, &obj->mmap, list) {

-               if ((prev_end <= start) && (start + bytes < tmp->da_start))
+               if ((prev_end <= start) && (start + bytes <= tmp->da_start))
                        goto found;

                if (flags & IOVMF_DA_ANON)
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/