linux-kernel - Re: struct fanotify_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201008191807.02031.agruen@suse.de>
Date:	Thu, 19 Aug 2010 18:07:01 +0200
From:	Andreas Gruenbacher <agruen@...e.de>
To:	Tvrtko Ursulin <tvrtko.ursulin@...hos.com>
Cc:	Andreas Schwab <schwab@...ux-m68k.org>,
	Eric Paris <eparis@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: struct fanotify_event_metadata

On Thursday 19 August 2010 17:44:29 Tvrtko Ursulin wrote:
> On Saturday 14 Aug 2010 18:44:38 Andreas Schwab wrote:
> > The pid field of struct fanotify_event_metadata has 64 bits which looks
> > excessive.  Wouldn't it make sense to make it 32 bits and swap it with
> > the mask field?  That would avoid the unaligned mask field, and remove
> > the need for the packed attribute.
> 
> No one seems to have picked up on this what I thought was an obvious good
> idea.

Yes, the pid field should be shrunk; it is a 32-bit value in user-space even 
on 64-bit platforms.  I also don't see that we'll ever need a 64-bit mask 
actually.

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/