linux-kernel - Re: struct fanotify_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201008191735.41985.tvrtko.ursulin@sophos.com>
Date:	Thu, 19 Aug 2010 17:35:41 +0100
From:	Tvrtko Ursulin <tvrtko.ursulin@...hos.com>
To:	Andreas Gruenbacher <agruen@...e.de>
CC:	Andreas Schwab <schwab@...ux-m68k.org>,
	Eric Paris <eparis@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: struct fanotify_event_metadata

On Thursday 19 Aug 2010 17:07:01 Andreas Gruenbacher wrote:
> On Thursday 19 August 2010 17:44:29 Tvrtko Ursulin wrote:
> > On Saturday 14 Aug 2010 18:44:38 Andreas Schwab wrote:
> > > The pid field of struct fanotify_event_metadata has 64 bits which looks
> > > excessive.  Wouldn't it make sense to make it 32 bits and swap it with
> > > the mask field?  That would avoid the unaligned mask field, and remove
> > > the need for the packed attribute.
> >
> > No one seems to have picked up on this what I thought was an obvious good
> > idea.
>
> Yes, the pid field should be shrunk; it is a 32-bit value in user-space
> even on 64-bit platforms.  I also don't see that we'll ever need a 64-bit
> mask actually.

You could be probably right since even though at the moment there are 23 bits
already allocated (purely mechanical count), protocol is future proof to
expand it later if needed.

On the other hand since it the same mask as in the syscall (where we really
want to have enough width top begin with) it is nice that both user interfaces
agree on the field width and it is probably a negligible overhead anyway.

Tvrtko

Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.
Company Reg No 2096520. VAT Reg No GB 348 3873 20.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/