linux-kernel - Re: [patch 00/10] ioctls: Convert ten architectures to asm-generic/ioctls.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201008210022.28726.arnd@arndb.de>
Date:	Sat, 21 Aug 2010 00:22:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jeff Mahoney <jeffm@...e.com>, Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Koichi Yasutake <yasutake.koichi@...panasonic.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Mikael Starvik <starvik@...s.com>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Russell King <linux@....linux.org.uk>,
	Tony Luck <tony.luck@...el.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: Re: [patch 00/10] ioctls: Convert ten architectures to asm-generic/ioctls.h

On Friday 20 August 2010 23:14:01 Jeff Mahoney wrote:
> - The generic list contains the termiox ioctl set. This seems to have
>   been added to x86 with the expectation that other arch maintainers
>   would add it to their own. New architectures have inherited this
>   automatically via asm-generic/ioctls.h and there isn't anything
>   inherently architecture specific about it. It's safe to just
>   add it to the affected architectures. If there is resistance to
>   this, I can submit a separate patchset to enable it on those
>   architectures and THEN apply this patchet, but it seems like a
>   waste of time.

Note that AFAICT there is not a single device driver that implements
the {set,get}_termiox functions, but enablign it does add extra code.

Alan added the infrastructure two years ago (see below), but it
seems we never adopted the use, or all the drivers using it were
already phased out again in the meantime.

I very much welcome making all architectures use the asm-generic/ioctls.h
file, that's why I added it in the first place. Whether or not we
actually want to have termiox support enabled without any drivers
using it is a separate question, but this would be a good time to
answer it.

	Arnd

---
commit 1d65b4a088de407e99714fdc27862449db04fb5c
Author: Alan Cox <alan@...hat.com>
Date:   Mon Oct 13 10:38:18 2008 +0100

    tty: Add termiox
    
    We need a way to describe the various additional modes and flow control
    features that random weird hardware shows up and software such as wine
    wants to emulate as Windows supports them.
    
    TCGETX/TCSETX and the termiox ioctl are a SYS5 extension that we might as
    well adopt. This patches adds the structures and the basic ioctl interfaces
    when the TCGETX etc defines are added for an architecture. Drivers wishing
    to use this stuff need to add new methods.
    
    Signed-off-by: Alan Cox <alan@...hat.com>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/