| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100820222450.GA28193@boomer> Date: Fri, 20 Aug 2010 17:24:50 -0500 From: Tyler Hicks <tyhicks@...ux.vnet.ibm.com> To: Jerome Marchand <jmarchan@...hat.com> Cc: Dustin Kirkland <kirkland@...onical.com>, ecryptfs-devel@...ts.launchpad.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ecryptfs: properly mark init functions On Thu Aug 19, 2010 at 10:24:00AM +0200, Jerome Marchand <jmarchan@...hat.com> wrote: > On 08/19/2010 02:28 AM, Tyler Hicks wrote: > > On Tue Aug 17, 2010 at 05:24:05PM +0200, Jerome Marchand <jmarchan@...hat.com> wrote: > >> > >> Some ecryptfs init functions are not prefixed by __init and thus not > >> freed after initialization. This patch saved about 1kB in ecryptfs > >> module. > >> > >> Signed-off-by: Jerome Marchand <jmarchan@...hat.com> > >> --- > > > > Thanks Jerome - We could also get away with marking > > ecryptfs_init_kmem_caches() and do_sysfs_registration() with __init, > > right? > > > > Tyler > > > > I guess we could. But it doesn't really matter, these are static functions which > are called from only one place, so they're inlined anyway. I don't know what the > convention is in such case. > Good point - this has been applied to git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next Thanks, Tyler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists