[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikM44mbBdYt1EWgXJYEFqY4F0_umG74-6eL2xW=@mail.gmail.com>
Date: Sat, 21 Aug 2010 09:35:44 +0200
From: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@...il.com>
To: Stefan Richter <stefanr@...6.in-berlin.de>
Cc: Miloslav Trmač <mitr@...hat.com>,
Herbert Xu <herbert@...dor.hengli.com.au>,
linux-crypto@...r.kernel.org, Neil Horman <nhorman@...hat.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/19] User-space API definition
2010/8/20 Stefan Richter <stefanr@...6.in-berlin.de>:
>> +struct ncr_session_input_data {
>> + const void __user *data;
>> + __kernel_size_t data_size;
>> +};
>> +
>> +};
> Why not using fixed-size fit-all members?
> struct ncr_session_input_data {
> __u64 data; /* user pointer, cast to/from u64 */
> __u32 data_size; /* or __u64? */
> };
A reason is that using (void*) is cleaner as an API. It avoids the
pointer to int casting and the warnings that such a cast will have.
regards,
Nikos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists