linux-kernel - Re: [PATCH 01/19] User-space API definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88057790.1047131282381902365.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
Date:	Sat, 21 Aug 2010 05:11:42 -0400 (EDT)
From:	Miloslav Trmac <mitr@...hat.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Herbert Xu <herbert@...dor.hengli.com.au>,
	linux-crypto@...r.kernel.org,
	Nikos Mavrogiannopoulos <n.mavrogiannopoulos@...il.com>,
	Neil Horman <nhorman@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/19] User-space API definition

----- "Stefan Richter" <stefanr@...6.in-berlin.de> wrote:
> Miloslav Trmač wrote:
> > --- /dev/null
> > +++ b/include/linux/ncr.h
> [...]
> > +struct ncr_session_input_data {
> > +	const void __user *data;
> > +	__kernel_size_t data_size;
> > +};
> 
> Why not using fixed-size fit-all members?
> 
> struct ncr_session_input_data {
> 	__u64 data;		/* user pointer, cast to/from u64 */
> 	__u32 data_size;	/* or __u64? */
> };
> 
> And then get rid of all the COMAPT code paths.
That would make the interface less natural, and any architecture that wanted to have larger pointers (I understand IBM did this back the '80s, so it can happen again) would result in a significantly worse mess than the widely used compat_ioctl mechanism.
    Mirek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/