linux-kernel - Re: [PATCH 1/2] MFD: Align ab8500 with the abx500 interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Aug 2010 11:14:35 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Mattias Wallin <mattias.wallin@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] MFD: Align ab8500 with the abx500 interface

2010/8/20 Samuel Ortiz <sameo@...ux.intel.com>:
> On Tue, Aug 17, 2010 at 11:24:37AM +0200, Mattias Wallin wrote:

>> This patch makes the ab8500 mixed signal chip expose the same
>> interface for register access as the ab3100, ab3550 and ab5500 chip.
>> The ab8500_read() and ab8500_write() is removed and replaced with
>> abx500_get_register_interruptible() and
>> abx500_set_register_interruptible().

> Thanks for the patch, but I'd prefer to see it split into 3 separate ones, for
> mfd, rtc and regulator. And then have the relevant maintaines cc'ed with those
> patches.

... but that will have the side effect of making it non-bisectable will
it not? If we change the interface of AB8500 to abx500.h in one
patch that breaks the users and the order is not restored until all
patches are applied.

Isn't it better to just resend the same patch and Cc: the relevant
subsystem maintainers on it?

I'll sign it off and do this, I should've been in the submit path
anyway.

If you prefer to have it non-bisectable I'll post yet another version
for that.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/