linux-kernel - Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter for tps6586x_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7248C3.9040304@compulab.co.il>
Date:	Mon, 23 Aug 2010 13:09:07 +0300
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Gary King <gking@...dia.com>
CC:	Axel Lin <axel.lin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameter
 for tps6586x_set_bits()

Mark Brown wrote:
> On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote:
>> The third parameter of tps6586x_set_bits() is the bit_mask,
>> thus we should use (1 << ri->go_bit) instead of ri->go_bit.
>>
>> Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> but I'd be much happier if someone who actually has the hardware could
> verify that this is OK.

I don't have the hardware handy at the moment.
Gary, can you please verify the fix?

-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/