linux-kernel - Re: [PATCH 2/6] btrfs: add helper function free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Aug 2010 09:03:21 -0400
From:	Josef Bacik <josef@...hat.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Chris Mason <chris.mason@...cle.com>,
	Josef Bacik <josef@...hat.com>, linux-btrfs@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] btrfs: add helper function free_bitmap()

On Mon, Aug 23, 2010 at 09:23:01AM +0800, Li Zefan wrote:
> Remove some duplicated code.
> 
> This prepares for the next patch.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
>  fs/btrfs/free-space-cache.c |   37 ++++++++++++++++---------------------
>  1 files changed, 16 insertions(+), 21 deletions(-)
> 
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 7edbef6..017fd55 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -422,6 +422,16 @@ static void add_new_bitmap(struct btrfs_block_group_cache *block_group,
>  	recalculate_thresholds(block_group);
>  }
>  
> +static void free_bitmap(struct btrfs_block_group_cache *block_group,
> +			struct btrfs_free_space *bitmap_info)
> +{
> +	unlink_free_space(block_group, bitmap_info);
> +	kfree(bitmap_info->bitmap);
> +	kfree(bitmap_info);
> +	block_group->total_bitmaps--;
> +	recalculate_thresholds(block_group);
> +}
> +
>  static noinline int remove_from_bitmap(struct btrfs_block_group_cache *block_group,
>  			      struct btrfs_free_space *bitmap_info,
>  			      u64 *offset, u64 *bytes)
> @@ -462,13 +472,8 @@ again:
>  
>  	if (*bytes) {
>  		struct rb_node *next = rb_next(&bitmap_info->offset_index);
> -		if (!bitmap_info->bytes) {
> -			unlink_free_space(block_group, bitmap_info);
> -			kfree(bitmap_info->bitmap);
> -			kfree(bitmap_info);
> -			block_group->total_bitmaps--;
> -			recalculate_thresholds(block_group);
> -		}
> +		if (!bitmap_info->bytes)
> +			free_bitmap(block_group, bitmap_info);
>  
>  		/*
>  		 * no entry after this bitmap, but we still have bytes to
> @@ -501,13 +506,8 @@ again:
>  			return -EAGAIN;
>  
>  		goto again;
> -	} else if (!bitmap_info->bytes) {
> -		unlink_free_space(block_group, bitmap_info);
> -		kfree(bitmap_info->bitmap);
> -		kfree(bitmap_info);
> -		block_group->total_bitmaps--;
> -		recalculate_thresholds(block_group);
> -	}
> +	} else if (!bitmap_info->bytes)
> +		free_bitmap(block_group, bitmap_info);
>  
>  	return 0;
>  }
> @@ -936,13 +936,8 @@ u64 btrfs_find_space_for_alloc(struct btrfs_block_group_cache *block_group,
>  	ret = offset;
>  	if (entry->bitmap) {
>  		bitmap_clear_bits(block_group, entry, offset, bytes);
> -		if (!entry->bytes) {
> -			unlink_free_space(block_group, entry);
> -			kfree(entry->bitmap);
> -			kfree(entry);
> -			block_group->total_bitmaps--;
> -			recalculate_thresholds(block_group);
> -		}
> +		if (!entry->bytes)
> +			free_bitmap(block_group, entry);
>  	} else {
>  		unlink_free_space(block_group, entry);
>  		entry->offset += bytes;
> -- 
> 1.7.0.1
> 

Reviewed-by: Josef Bacik <josef@...hat.com>

Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/