[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100823130438.GC2404@localhost.localdomain>
Date: Mon, 23 Aug 2010 09:04:38 -0400
From: Josef Bacik <josef@...hat.com>
To: Li Zefan <lizf@...fujitsu.com>
Cc: Chris Mason <chris.mason@...cle.com>,
Josef Bacik <josef@...hat.com>, linux-btrfs@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] btrfs: free fully occupied bitmap in cluster
On Mon, Aug 23, 2010 at 09:23:16AM +0800, Li Zefan wrote:
> If there's no more free space in a bitmap, we should free it,
> otherwise seems it won't get freed until we free the block group.
>
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
> fs/btrfs/free-space-cache.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 017fd55..631e14f 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -1035,6 +1035,8 @@ static u64 btrfs_alloc_from_bitmap(struct btrfs_block_group_cache *block_group,
>
> ret = search_start;
> bitmap_clear_bits(block_group, entry, ret, bytes);
> + if (entry->bytes == 0)
> + free_bitmap(block_group, entry);
> out:
> spin_unlock(&cluster->lock);
> spin_unlock(&block_group->tree_lock);
> --
> 1.7.0.1
>
Oops, good catch
Reviewed-by: Josef Bacik <josef@...hat.com>
Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists