linux-kernel - Re: [PATCH] ACPI: Don't report current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Aug 2010 12:18:22 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Matthew Garrett <mjg@...hat.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, dwmw2@...radead.org, lenb@...nel.org,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Zhang Rui <rui.zhang@...el.com>,
	Alexey Starikovskiy <astarikovskiy@...e.de>
Subject: Re: [PATCH] ACPI: Don't report current_now if battery reports in
 mWh

On Mon, Aug 23, 2010 at 11:37:19PM +0200, Rafael J. Wysocki wrote:
> On Monday, August 23, 2010, Matthew Garrett wrote:
> > ACPI batteries can report in units of either current or energy. Right
> > now we expose the current_now file even if the battery is reporting
> > energy units, resulting in a file that should contain mA instead
> > containing mW. Don't expose this value unless the battery is reporting
> > current.
> > 
> > Signed-off-by: Matthew Garrett <mjg@...hat.com>
> > Cc: Arjan van de Ven <arjan@...ux.intel.com>
> 
> Acked-by: Rafael J. Wysocki <rjw@...k.pl>

Looks good to me as well.

Should I merge this into the battery-2.6.git tree, or
ACPI folks are gonna handle this patch?

Thanks,

> > ---
> >  drivers/acpi/battery.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> > index dc58402..9841720 100644
> > --- a/drivers/acpi/battery.c
> > +++ b/drivers/acpi/battery.c
> > @@ -273,7 +273,6 @@ static enum power_supply_property energy_battery_props[] = {
> >  	POWER_SUPPLY_PROP_CYCLE_COUNT,
> >  	POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
> >  	POWER_SUPPLY_PROP_VOLTAGE_NOW,
> > -	POWER_SUPPLY_PROP_CURRENT_NOW,
> >  	POWER_SUPPLY_PROP_POWER_NOW,
> >  	POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN,
> >  	POWER_SUPPLY_PROP_ENERGY_FULL,
> > 

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/