linux-kernel - Re: workqueue destruction BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282655865.3695.27.camel@jlt3.sipsolutions.net>
Date:	Tue, 24 Aug 2010 15:17:45 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Tejun Heo <tj@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: workqueue destruction BUG_ON

On Tue, 2010-08-24 at 15:07 +0200, Tejun Heo wrote:

> > [  500.874185] ------------[ cut here ]------------
> > [  500.875212] kernel BUG at kernel/workqueue.c:2849!
> 
> Are you sure you're running the patched kernel?  With the patch
> applied, the BUG_ON() wouldn't be on line 2849 (on both rc1 and 2).

Yes:

void destroy_workqueue(struct workqueue_struct *wq)
{
        unsigned int cpu;
   
        wq->flags |= WQ_DYING;
        flush_workqueue(wq);
  
        /*
         * wq list is used to freeze wq, remove from list after
         * flushing is complete in case freeze races us.
         */
        spin_lock(&workqueue_lock);
        list_del(&wq->list);
        spin_unlock(&workqueue_lock);

        /* sanity check */
        for_each_cwq_cpu(cpu, wq) {
                struct cpu_workqueue_struct *cwq = get_cwq(cpu, wq);
                int i;

                for (i = 0; i < WORK_NR_COLORS; i++)
                        BUG_ON(cwq->nr_in_flight[i]);
2849:           BUG_ON(cwq->nr_active);
                BUG_ON(!list_empty(&cwq->delayed_works));


Applying the patch reported some offset, but the kernel is just rc1 +
wireless stuff.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/