linux-kernel - Re: [PATCH] drm/i915/tv: After disabling the pipe, use wait_for_vblank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282684130.2199.25.camel@localhost.localdomain>
Date:	Tue, 24 Aug 2010 23:08:50 +0200
From:	Ivan Bulatovic <combuster@....com>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	linux-kernel@...r.kernel.org, linux-gfx@...ts.freedesktop.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] drm/i915/tv: After disabling the pipe, use
 wait_for_vblank_off()

On Tue, 2010-08-24 at 16:11 +0100, Chris Wilson wrote: 
> Hopefully this is a contributing factor to the spurious TV detection
> repoted by Ivan Bulatovic and others.
> 
> References:
> 
>   Bug 16871 - "TV1 connected" with no tv
>   https://bugzilla.kernel.org/show_bug.cgi?id=16871
> 
> Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> Reported-by: Ivan Bulatovic <combuster@....com>
> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_tv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index f70bc76..f96289d 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -1171,7 +1171,7 @@ intel_tv_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
>  		I915_WRITE(pipeconf_reg, pipeconf & ~PIPEACONF_ENABLE);
>  		POSTING_READ(pipeconf_reg);
>  		/* Wait for vblank for the disable to take effect. */
> -		intel_wait_for_vblank(dev, intel_crtc->pipe);
> +		intel_wait_for_vblank_off(dev, intel_crtc->pipe);
>  
>  		/* Filter ctl must be set before TV_WIN_SIZE */
>  		I915_WRITE(TV_FILTER_CTL_1, TV_AUTO_SCALE);

Unfotunately I still get TV connection detected :(

View attachment "dmesg.log" of type "text/x-log" (153829 bytes)