linux-kernel - RE: [PATCH 2/2] drivers/serial/bfin_5xx.c: Use pr_<level> and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.30.1008232025260.31237-100000@mail.perches.com>
Date:	Mon, 23 Aug 2010 20:30:14 -0700 (PDT)
From:	Joe Perches <joe@...ches.com>
To:	"Zhang, Sonic" <Sonic.Zhang@...log.com>
cc:	<linux-kernel@...r.kernel.org>,
	<uclinux-dist-devel@...ckfin.uclinux.org>
Subject: RE: [PATCH 2/2] drivers/serial/bfin_5xx.c: Use pr_<level> and pr_<fmt>

On Tue, 24 Aug 2010, Zhang, Sonic wrote:
> >Also fix typo of length.
> >Signed-off-by: Joe Perches <joe@...ches.com>
> >-		pr_info("Unable to attach BlackFin UART Modem "
> >-			"Status interrupt.\n");
> >+		pr_info("Unable to attach BlackFin UART Modem
> >Status interrupt\n");
> I don't this this change is necessary.

Linus once said he doesn't like splitting
format lines because it makes grep more
difficult.

http://lkml.org/lkml/2009/12/17/229

> How about following style?
>
> 			pr_warning( "STOP bits other than 1 is not "
> 				"supported in case of anomaly
> 05000231.\n");

Fix it up as you prefer.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/