linux-kernel - Re: [PATCH 2/2] drivers/serial/bfin_5xx.c: Use pr_<level> and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTin6jwj0Eo4fDm3Tm3Jp6er+G8t_ioQU6GiBjtu5@mail.gmail.com>
Date:	Mon, 23 Aug 2010 23:47:53 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"Zhang, Sonic" <Sonic.Zhang@...log.com>,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 2/2] drivers/serial/bfin_5xx.c: Use pr_<level> and pr_<fmt>

On Mon, Aug 23, 2010 at 23:30, Joe Perches wrote:
> On Tue, 24 Aug 2010, Zhang, Sonic wrote:
>> >Also fix typo of length.
>> >Signed-off-by: Joe Perches <joe@...ches.com>
>> >-            pr_info("Unable to attach BlackFin UART Modem "
>> >-                    "Status interrupt.\n");
>> >+            pr_info("Unable to attach BlackFin UART Modem
>> >Status interrupt\n");
>> I don't this this change is necessary.
>
> Linus once said he doesn't like splitting
> format lines because it makes grep more
> difficult.
>
> http://lkml.org/lkml/2009/12/17/229

ah, i hadnt realized sanity had come to town.  this was one of my
largest gripes about string splitting ... having to figure out the
magic variation in substrings for grep to find a match.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/