linux-kernel - Re: [PATCH v2 1/2] compaction: handle active and inactive fairly in too_many

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikE-_=8GCu=LjLiyyO9W+soSKAC0bkXfYAnwMux@mail.gmail.com>
Date:	Thu, 26 Aug 2010 18:39:49 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Wu Fengguang <fengguang.wu@...el.com>,
	Iram Shahzad <iram.shahzad@...fujitsu.com>
Subject: Re: [PATCH v2 1/2] compaction: handle active and inactive fairly in too_many_isolated

On Thu, Aug 26, 2010 at 6:03 PM, Mel Gorman <mel@....ul.ie> wrote:
> On Wed, Aug 25, 2010 at 12:31:18AM +0900, Minchan Kim wrote:
>> Iram reported compaction's too_many_isolated loops forever.
>> (http://www.spinics.net/lists/linux-mm/msg08123.html)
>>
>> The meminfo of situation happened was inactive anon is zero.
>> That's because the system has no memory pressure until then.
>> While all anon pages was in active lru, compaction could select
>> active lru as well as inactive lru. That's different things
>> with vmscan's isolated. So we has been two too_many_isolated.
>>
>> While compaction can isolated pages in both active and inactive,
>> current implementation of too_many_isolated only considers inactive.
>> It made Iram's problem.
>>
>> This patch handles active and inactive with fair.
>> That's because we can't expect where from and how many compaction would
>> isolated pages.
>>
>> This patch changes (nr_isolated > nr_inactive) with
>> nr_isolated > (nr_active + nr_inactive) / 2.
>>
>> Cc: Iram Shahzad <iram.shahzad@...fujitsu.com>
>> Acked-by: Mel Gorman <mel@....ul.ie>
>> Acked-by: Wu Fengguang <fengguang.wu@...el.com>
>> Signed-off-by: Minchan Kim <minchan.kim@...il.com>
>
> Please send this patch on its own as it looks like it should be merged and
> arguably is a stable candidate for 2.6.35. Alternatively, Andrew, can you pick
> up just this patch? It seems unrelated to the second patch on COMPACTPAGEFAILED.

I thought it's not urgent and next patch would apply based on this
patch without HUNK.
If Andrew doesn't have a response, I will resend as a standalone.
Thanks.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/