linux-kernel - Re: [RFC PATCH 01/43] ptrace: change signature of sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201008271521.35995.arnd@arndb.de>
Date:	Fri, 27 Aug 2010 15:21:35 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Roland McGrath <roland@...hat.com>,
	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 01/43] ptrace: change signature of sys_ptrace() and friends

On Friday 27 August 2010, Namhyung Kim wrote:
> Since user space API of ptrace syscall defines @addr and @data as void
> pointers, it would be more appropriate to define them as unsigned long
> in kernel. Therefore related functions are changed also.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Namhyung Kim <namhyung@...il.com>

Looks good to me. It may be worth mentioning in the changelog that
'unsigned long' is typically used in other places in the kernel
as an opaque data type and that using this helps cleaning up a lot
of warnings from sparse.

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/