linux-kernel - Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100828163725.GI9832@bicker>
Date:	Sat, 28 Aug 2010 18:37:25 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	Thomas Dahlmann <dahlmann.thomas@...or.de>,
	kernel-janitors@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

On Sat, Aug 28, 2010 at 05:41:01PM +0200, Julia Lawall wrote:
> This is a guess as to what the code should be.  Perhaps something else
> should have been tested instead.
> 
>  drivers/usb/gadget/amd5536udc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index 731150d..6c40c99 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -203,7 +203,7 @@ static void print_regs(struct udc *dev)
>  		DBG(dev, "DMA mode       = PPBNDU (packet per buffer "
>  			"WITHOUT desc. update)\n");
>  		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
> -	} else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
> +	} else if (use_dma && use_dma_ppb_du) {


My guess is that "use_dma_ppb" was intended.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/