linux-kernel - Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1008281916580.13508@ask.diku.dk>
Date:	Sat, 28 Aug 2010 19:17:16 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	David Brownell <david-b@...bell.net>,
	Thomas Dahlmann <dahlmann.thomas@...or.de>,
	kernel-janitors@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

On Sat, 28 Aug 2010, Stefan Richter wrote:

> Julia Lawall wrote:
> > On Sat, 28 Aug 2010, David Brownell wrote:
> > 
> >> Please update $SUBJECT to say which driver is
> >> affected;
> > 
> > Done.
> > 
> >> it's not everything in that directory,
> >> and accurate GIT summaries help a lot.
> > 
> > Is there some sort of rule that can be followed?  For example, if the 
> > patch affects only one, file, should that file be named?  What if the 
> > patch affects only two files?
> 
> gitk $path or git shortlog $path, with $path being the file or directory, give
> a quick impression how the resident developers call their driver or subsystem
> updates.  E.g. ^USB: instead of ^drivers/usb/.
> 
> However, the committer could still adjust the title, so no drama if the patch
> subject as written by a cross-tree developer looks different from those of the
> usual subsystem patches.  IMO this is one of the tasks of a subsystem
> maintainer.  And it is quickly enough done with a git commit --amend.
> 
> There is only a drawbackif the subject is too broad /and/ if the Cc list is
> too short;  a driver developer may miss to see the submission.  The danger of
> that is low though when get_maintainer.pl is used to good effect.

OK, thanks.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/