linux-kernel - Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <620873.86430.qm@web180307.mail.gq1.yahoo.com>
Date:	Sat, 28 Aug 2010 11:11:07 -0700 (PDT)
From:	David Brownell <david-b@...bell.net>
To:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Julia Lawall <julia@...u.dk>
Cc:	Thomas Dahlmann <dahlmann.thomas@...or.de>,
	kernel-janitors@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test



--- On Sat, 8/28/10, Julia Lawall <julia@...u.dk> wrote:

> From: Julia Lawall <julia@...u.dk>
> Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test
> To: "Stefan Richter" <stefanr@...6.in-berlin.de>
> Cc: "David Brownell" <david-b@...bell.net>, "Thomas Dahlmann" <dahlmann.thomas@...or.de>, kernel-janitors@...r.kernel.org, "David Brownell" <dbrownell@...rs.sourceforge.net>, "Greg Kroah-Hartman" <gregkh@...e.de>, linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
> Date: Saturday, August 28, 2010, 10:17 AM
> On Sat, 28 Aug 2010, Stefan Richter
> wrote:
> 
> > Julia Lawall wrote:
> > > On Sat, 28 Aug 2010, David Brownell wrote:
> > > 
> > >> Please update $SUBJECT to say which driver
> is
> > >> affected;
> > > 
> > > Done.

Thanks.  Unless the author/maintainer of this
driver objects, the patch is OK by me.


> > > 
> > >> it's not everything in that directory,
> > >> and accurate GIT summaries help a lot.
> > > 
> > > Is there some sort of rule that can be
> followed? 

Don't be misleading ...

Generally, if it updates just one driver,
mention that driver in $SUBJECT.

Only say the subsystem itself is being
updated (which your original $SUBJECT did)
when the patch affects framework code, 
that's shared by all drivers, 

 > > >  What if the 
> > > patch affects only two files?

Which two files?
The "patch updates one thing" rule will then
cause it to affect only one driver (usually)
or some framework issue, so the above policies
kick in directly.

Rarely there will be bugs repeated (e.g. via
cut/paste) in multiple drivers, ... in which
 case  it can make sense to summarize a patch
as a multi-driver subsystem fix .  Similarly
with API changes.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/