linux-kernel - Re: Comments to apparmor Makefile (and security/Makefile)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Aug 2010 21:21:55 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	John Johansen <john.johansen@...onical.com>
Cc:	James Morris <jmorris@...ei.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: Comments to apparmor Makefile (and security/Makefile)

> 
> > 8) From security/Makefile:
> > 
> >     obj-$(CONFIG_SECURITY_APPARMOR)         += apparmor/built-in.o
> > This is _not_ how we do it.
> > 
> > We say just:
> > 
> >     obj-$(CONFIG_SECURITY_APPARMOR)         += apparmor/
> > 
> > [security/Makefile has this issue in several places]
> > 
> okay, I set it up this way to conform to other entries in the file
> If we are going to fix apparmor's entry we should fix them all

Agreed - its better to fix them all in one go.
I assume you do this in a follow-up patch - it is straightforward.

> 
> > There was a few tings that made me unsafe just providing a patch,
> > so for now you got a list of comments.
> > 
> > 	Sam
> 
> np, thanks for the comments, patch attached
Looks much better - and thanks for the quick response!

Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/