[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4C7BEA30.1090000@kernel.org>
Date: Mon, 30 Aug 2010 19:28:16 +0200
From: Tejun Heo <tj@...nel.org>
To: Jeffrey Carlyle <jeff.carlyle@...orola.com>
CC: OLUSANYA SOYANNWO <olusanya.soyannwo@...orola.com>,
linux-kernel@...r.kernel.org, Hu Tao <taohu@...orola.com>,
jaxboe@...ionio.com, torvalds@...l.org
Subject: Re: [PATCH v6] scatterlist: prevent invalid free when alloc fails
On 08/30/2010 06:19 PM, Jeffrey Carlyle wrote:
> When alloc fails, free_table is being called. Depending on the number of
> bytes requested, we determine if we are going to call _get_free_page()
> or kmalloc(). When alloc fails, our math is wrong (due to sg_size - 1),
> and the last buffer is wrongfully assumed to have been allocated by
> kmalloc. Hence, kfree gets called and a panic occurs.
>
> Signed-off-by: Jeffrey Carlyle <jeff.carlyle@...orola.com>
> Signed-off-by: Olusanya Soyannwo <c23746@...orola.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Jens Axboe <jaxboe@...ionio.com>
Acked-by: Tejun Heo <tj@...nel.org>
Thanks. :-)
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists