linux-kernel - Re: [PATCH v6] scatterlist: prevent invalid free when alloc fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C7BF0C8.8070505@fusionio.com>
Date:	Mon, 30 Aug 2010 19:56:24 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Jeffrey Carlyle <jeff.carlyle@...orola.com>
CC:	Tejun Heo <tj@...nel.org>,
	OLUSANYA SOYANNWO <olusanya.soyannwo@...orola.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hu Tao <taohu@...orola.com>,
	"torvalds@...l.org" <torvalds@...l.org>
Subject: Re: [PATCH v6] scatterlist: prevent invalid free when alloc fails

On 2010-08-30 18:19, Jeffrey Carlyle wrote:
> When alloc fails, free_table is being called. Depending on the number of
> bytes requested, we determine if we are going to call _get_free_page()
> or kmalloc(). When alloc fails, our math is wrong (due to sg_size - 1),
> and the last buffer is wrongfully assumed to have been allocated by
> kmalloc. Hence, kfree gets called and a panic occurs.

That's a lot of revs, thanks for getting it done (and Tejun for
the careful reviews).

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/