linux-kernel - Re: [PATCH] USB: output an error message when the pipe type doesn't match the endpoint type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1009021516100.1311-100000@iolanthe.rowland.org>
Date:	Thu, 2 Sep 2010 15:20:52 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Simon Arlott <simon@...e.lp0.eu>
cc:	Greg KH <greg@...ah.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] USB: output an error message when the pipe type  doesn't
 match the endpoint type

On Thu, 2 Sep 2010, Simon Arlott wrote:

> On 02/09/10 15:22, Alan Stern wrote:
> > On Thu, 2 Sep 2010, Simon Arlott wrote:
> > 
> >> On Wed, September 1, 2010 18:49, Alan Stern wrote:
> >> > On Wed, 1 Sep 2010, Simon Arlott wrote:
> >> >> > This is okay with me.  If you're serious about not changing the
> >> >> > behavior merely because debugging is enabled, you could move this test
> >> >> > out of the debug-only region and possibly change the dev_err to
> >> >> > dev_dbg.  However doing so might break some devices that are currently
> >> >> > working.
> > 
> > Which suggests that the best approach is to print the error message 
> > always, but allow the submission unless CONFIG_USB_DEBUG is set.
> 
> That could result in a lot of error messages, and it doesn't give any
> information on which driver caused it,

It would if you added the endpoint number and direction to the error 
message.

>  but a single WARN_ON() would
> only be triggered once globally. Each USB device (or endpoint) could
> have a "warned" flag.

That seems ridiculous, especially for such a rare bug.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/