linux-kernel - Re: kernelshark plugins and ftrace array fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283455443.2356.433.camel@gandalf.stny.rr.com>
Date:	Thu, 02 Sep 2010 15:24:03 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: kernelshark plugins and ftrace array fields

On Thu, 2010-09-02 at 14:38 -0400, Steven Rostedt wrote:

> I think I will add a:
> 
> void *pevent_get_field_raw(stuct trace_seq *s,
> 			struct event_format *event, 
> 			char *field_name,
> 			struct record *record,
> 			int **field_len);
> 
> which will return a pointer into record->data and set the field_len to
> the actual size.
> 
> This will be useful for dynamic arrays too, since it is more complex
> than just using a field->offset.

I just pushed out the changes and my new example looks like this:

static int
kvm_emulate_insn_handler(struct trace_seq *s, struct record *record,
                         struct event_format *event, void *context)
{
        unsigned char *data;
        int len;
        int i;

        data = pevent_get_field_raw(s, event, "insn", record,
                                    &len, 1);
        if (!data)
                return -1;

        trace_seq_puts(s, "insn: ");
        for (i = 0; i < len; i++) {
                trace_seq_printf(s, "%s%02x",
                                 i ? "," : "",
                                 data[i]);
        }

        return 0;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/