linux-kernel - Re: [PATCH 1/4] staging: xgifb: Fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100905062353.GA18329@suse.de>
Date:	Sat, 4 Sep 2010 23:23:53 -0700
From:	Greg KH <gregkh@...e.de>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>,
	Arnaud Patard <apatard@...driva.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Huang Weiyi <weiyi.huang@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: xgifb: Fix compile warning

On Sat, Sep 04, 2010 at 07:06:47PM -0400, Javier Martinez Canillas wrote:
> Hello, In today linux-next I got a some compile warnings with the staging/xgifb driver. This is the first of a 4 patchset that fix all the issues.
> 
> The patches are:
> 
> [PATCH 1/4] staging: xgifb: Fix compile warning
> [PATCH 2/4] staging: xgifb: Add compilation conditionals
> [PATCH 3/4] staging: xgifb: Removes unused variable
> [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues
> 
> Thanks a lot.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  drivers/staging/xgifb/XGI_main_26.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 7cd3e95..3c80191 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -3418,7 +3418,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
>  		XGIfb_registered = 1;
>  
>  		printk(KERN_INFO "XGIfb: Installed XGIFB_GET_INFO ioctl (%lx)\n",
> -		       XGIFB_GET_INFO);
> +		       (unsigned long)XGIFB_GET_INFO);

No, you should use %p instead.

Also, you don't spam the kernel log for assigning an ioctl function
pointer, that's just looney...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/