linux-kernel - Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 4 Sep 2010 23:24:26 -0700
From:	Greg KH <gregkh@...e.de>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Arnaud Patard <apatard@...driva.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Huang Weiyi <weiyi.huang@...il.com>
Subject: Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals

On Sat, Sep 04, 2010 at 07:07:48PM -0400, Javier Martinez Canillas wrote:
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  drivers/staging/xgifb/XGI_main.h    |    2 ++
>  drivers/staging/xgifb/XGI_main_26.c |    6 ++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> index 72448e8..93837f3 100644
> --- a/drivers/staging/xgifb/XGI_main.h
> +++ b/drivers/staging/xgifb/XGI_main.h
> @@ -345,7 +345,9 @@ static int XGIfb_userom = 0;
>  static int XGIfb_registered;
>  static int XGIfb_tvmode = 0;
>  static int XGIfb_mem = 0;
> +#ifndef MODULE
>  static int XGIfb_pdc = 0;
> +#endif

Ick, no, don't add conditionals, fix the code to not need such nonsense.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/