linux-kernel - Re: [PATCH] no need to align .modinfo strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009061749.56921.rusty@rustcorp.com.au>
Date:	Mon, 6 Sep 2010 17:49:55 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"Jan Beulich" <JBeulich@...ell.com>
Cc:	"Michal Marek" <mmarek@...e.cz>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] no need to align .modinfo strings

On Thu, 2 Sep 2010 09:54:40 pm Jan Beulich wrote:
> Their use is not performance critical, and hence it seems better to
> save some space.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

The real question is: why is gcc aligning these?  Should it be aligning
any string literals at all?  If so, should we look for other such wastes
of space?

Thanks,
Rusty.

> --- linux-2.6.36-rc3/include/linux/moduleparam.h
> +++ 2.6.36-rc3-modinfo-align/include/linux/moduleparam.h
> @@ -21,8 +21,8 @@
>  #define __module_cat(a,b) ___module_cat(a,b)
>  #define __MODULE_INFO(tag, name, info)					  \
>  static const char __module_cat(name,__LINE__)[]				  \
> -  __used								  \
> -  __attribute__((section(".modinfo"),unused)) = __stringify(tag) "=" info
> +  __used __attribute__((section(".modinfo"), unused, aligned(1)))	  \
> +  = __stringify(tag) "=" info
>  #else  /* !MODULE */
>  #define __MODULE_INFO(tag, name, info)
>  #endif
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/