linux-kernel - Re: [PATCH] no need to align .modinfo strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4C84C3CA0200007800014730@vpn.id2.novell.com>
Date:	Mon, 06 Sep 2010 09:34:50 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Rusty Russell" <rusty@...tcorp.com.au>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Michal Marek" <mmarek@...e.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] no need to align .modinfo strings

>>> On 06.09.10 at 10:19, Rusty Russell <rusty@...tcorp.com.au> wrote:
> On Thu, 2 Sep 2010 09:54:40 pm Jan Beulich wrote:
>> Their use is not performance critical, and hence it seems better to
>> save some space.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> Acked-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> The real question is: why is gcc aligning these?  Should it be aligning

A performance consideration for those cases where strings are being
used a lot, I believe.

> any string literals at all?  If so, should we look for other such wastes
> of space?

I think we should, at least I'm keeping an eye open to spot any such.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/