linux-kernel - Re: HIDDEV: potential NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTin+T2tB+oXu9BzUfBkPpxEe47+tSMr2Yf4_Lb=x@mail.gmail.com>
Date:	Mon, 6 Sep 2010 11:03:13 +0530
From:	Amit Nagal <helloin.amit@...il.com>
To:	Chris Ball <cjb@...top.org>
Cc:	Jiri Slaby <jslaby@...e.cz>, Jiri Kosina <jkosina@...e.cz>,
	linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Dan Carpenter <error27@...il.com>
Subject: Re: HIDDEV: potential NULL dereference

Hi ,

i was one of the users who informed that crash do disappears .

the reality with me is that the probability of occurence of crash
reduces significantly

but on rigourous testing crash resurfaces again .

sorry for wrong reporting .

Regards
Amit Nagal



On Sat, Sep 4, 2010 at 10:09 PM, Chris Ball <cjb@...top.org> wrote:
> Hi Jiri,
>
>   > If hid was ever NULL at this phase, the check couldn't improve
>   > anything due to hid->driver_data dereference being still before
>   > the check. So again my question, how this could change anything?
>   >
>   > Above that, it just makes the window shorter, but the bug is
>   > still there, isn't it? Is the following scenario reasonable?
>
> You're right -- I'd missed the other dereference, sorry.  It's
> surprising that we have two reports from users saying that the
> patch got rid of a reproducible oops for them.
>
> Dan Carpenter has commented on this too:
>   http://www.spinics.net/lists/linux-input/msg10541.html
>
> As he says, it looks like the code's overdue for some real locking.
>
> Thanks,
>
> - Chris.
> --
> Chris Ball   <cjb@...top.org>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/