linux-kernel - RE: [PATCH] USB: Fix kernel oops with g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB03293269CD@dbde02.ent.ti.com>
Date:	Tue, 7 Sep 2010 16:18:23 +0530
From:	"Gadiyar, Anand" <gadiyar@...com>
To:	Maxim Osipov <maxim.osipov@...il.com>,
	Sergei Shtylyov <sshtylyov@...sta.com>
CC:	Greg KH <gregkh@...e.de>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] USB: Fix kernel oops with g_ether and Windows

Maxim Osipov wrote:
> On Tue, Sep 7, 2010 at 1:55 PM, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
> >
> >   It was caught by me on the list too, right at the same day the patch was
> > posted. The author remained silent though...
> >

Sorry Sergei, I seem to have missed your mail on the list, and didn't
bother hunting in the list archives.

> 
> Sorry for being silent - I had lots of things to do. Regarding the
> patch itself - I respect kernel coding conventions, but I think it is
> bad to have two different code styles in one file. Note, this is my
> personal opinion only.
> 

I should have looked closer - I see now that you've only retained
the existing style.

Since Greg has already sent a pull request, I won't touch the file
now; maybe a trivial patch later on to fix up the coding style.

- Anand