linux-kernel - Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin7eVyosgK4XhuB_yqR2ao=YJGVidHB1x2802cr@mail.gmail.com>
Date:	Tue, 7 Sep 2010 19:20:06 +0530
From:	venki kaps <venkiece2005@...il.com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <me@...ipebalbi.com>,
	Anand Gadiyar <gadiyar@...com>
Subject: Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

thanks for your good response.

Venkii,

On Tue, Sep 7, 2010 at 6:54 PM, Ming Lei <tom.leiming@...il.com> wrote:
> 2010/9/7 venki kaps <venkiece2005@...il.com>:
>> Dear USB experts,
>>
>>  Is the same fix valid for omap3430 + 2.6.32 Kernel?
>>
>>  I have been facing mp3 playback idle current consumption 20mA more
>> after booting without USB cable connected
>>  but If USB cable detach and attach happen, then able to hit proper
>> values otherwise irrespective of cold/warm reset
>>  the current values increases to 20mA.
>>
>>  with cable,
>>      OTG_SYSCONFIG standby mode of operation - SMART idle
>>      HSOTGUSB_STANDBY - SMART standby
>>
>>  without cable,
>>        OTG_SYSCONFIG standby mode of operation - SMART idle
>>        HSOTGUSB_STANDBY - Active
>>
>>  Even i have applied  patch but still the same issue.
>
> Are you applying the patch below?
>
>         http://marc.info/?l=linux-omap&m=128378686221264&w=2
>
> The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against
> 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch
> is introduced to fix the problems caused by
>
>          commit 461c317705eca5cac09a360f488715927fd0a927.
>
> which change is committed into mainline 2.6.36-rc3.
  >>> Yes, this patch i have applied.

>>
>>  If i use __twl4030_phy_power(twl, 0) at the end of USB LDO initialization,
>
> If you apply this patch against 2.6.36-rc3, you will find
> __twl4030_phy_power(twl, 0)  is always called from .probe
> if you don't connect musb with PC via cable when powering on.
>
>>  then able to hit proper values but USB ADC values are getting in correct
>>  with Travel adapter (Charger power supply) which means temperature
>>  shows 84 instead of 26~30 degrees.
>>
>>  Queries,
>>  -----------
>>   - Is Errata 1.164 fix : OTG idle will work on 3430?
>
> No such errata found in ti wetsite, could you give a link?
   In Zoom3 git,pm34xx.c file
                        /*
                         * Errata 1.164 fix : OTG autoidle can prevent
                         * sleep. enable/disable iclk over OFF.
                         */
                        cm_rmw_mod_reg_bits(OMAP3430_EN_HSOTGUSB, 0x0,
                                                CORE_MOD, CM_ICLKEN1);

>
>>   - USBOTG_SUSPEND is enabled in Kernel 32, will it give any impact?
>
> Kernel does not have USBOTG_SUSPEND config option. Do you
> mean USB_SUSPEND? If so, it is nothing to do with your issue since
> it is only valid for host driver. Also for your case, musb works at
> b-idle state.
>
   Yes,CONFIG_USB_SUSPEND.

>>   - Is there anything missed from Power management idle path (or)
>>    USB OTG controller/Transreceiver driver part?
>
> Maybe with transreceiver part, musb doesn't support runtime pm now.
>
>>
>>  Could you please provide the best approach to solve my issue?
>
> Sorry, this patch is not for your issue, as said above.
>
>
> --
> Lei Ming
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/