linux-kernel - Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinrecJXH+uDxtBsskFLpBCz0VSZMtSiWGFW9YCr@mail.gmail.com>
Date:	Tue, 7 Sep 2010 23:40:55 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	venki kaps <venkiece2005@...il.com>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <me@...ipebalbi.com>,
	Anand Gadiyar <gadiyar@...com>
Subject: Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010/9/7 venki kaps <venkiece2005@...il.com>:
> thanks for your good response.
>
> Venkii,
>
> On Tue, Sep 7, 2010 at 6:54 PM, Ming Lei <tom.leiming@...il.com> wrote:
>> 2010/9/7 venki kaps <venkiece2005@...il.com>:
>>> Dear USB experts,
>>>
>>>  Is the same fix valid for omap3430 + 2.6.32 Kernel?
>>>
>>>  I have been facing mp3 playback idle current consumption 20mA more
>>> after booting without USB cable connected
>>>  but If USB cable detach and attach happen, then able to hit proper
>>> values otherwise irrespective of cold/warm reset
>>>  the current values increases to 20mA.
>>>
>>>  with cable,
>>>      OTG_SYSCONFIG standby mode of operation - SMART idle
>>>      HSOTGUSB_STANDBY - SMART standby
>>>
>>>  without cable,
>>>        OTG_SYSCONFIG standby mode of operation - SMART idle
>>>        HSOTGUSB_STANDBY - Active
>>>
>>>  Even i have applied  patch but still the same issue.
>>
>> Are you applying the patch below?
>>
>>         http://marc.info/?l=linux-omap&m=128378686221264&w=2
>>
>> The patch(USB: otg: twl4030: fix phy initialization(v1)) above is against
>> 2.6.36-rc3, I don't think you can apply it directly on 2.6.32. And the patch
>> is introduced to fix the problems caused by
>>
>>          commit 461c317705eca5cac09a360f488715927fd0a927.
>>
>> which change is committed into mainline 2.6.36-rc3.
>  >>> Yes, this patch i have applied.

If you applied the patch, I guess you may see __twl4030_phy_power(twl, 0)
is called from .probe.

If called,  seems your description a little contradictory since you observed
__twl4030_phy_power(twl, 0) may hit proper values, right?

If not called, could you trace the return value of twl4030_usb_linkstat in
twl4030_usb_phy_init?

thanks,

-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/