linux-kernel - Re: [PATCH 11/13] net/ipv4: Remove unnecessary casts of private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100906.184749.214227378.davem@davemloft.net>
Date:	Mon, 06 Sep 2010 18:47:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	trivial@...nel.org, kuznet@....inr.ac.ru, pekkas@...core.fi,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/13] net/ipv4: Remove unnecessary casts of
 private_data

From: David Miller <davem@...emloft.net>
Date: Mon, 06 Sep 2010 18:30:36 -0700 (PDT)

> From: Joe Perches <joe@...ches.com>
> Date: Sat,  4 Sep 2010 18:52:52 -0700
> 
>> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> Applied.

So Joe, did you even friggin' build test this?

raw_seq_private() expands to something which dereferences the pointer,
which you've now made void, which is illegal and breaks the build.

Reverted.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/