linux-kernel - Re: [PATCH v3] scsi_debug: Convert to use root_device_register() and root_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Sep 2010 20:58:03 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	James Bottomley <James.Bottomley@...e.de>
Cc:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Douglas Gilbert <dgilbert@...erlog.com>,
	Richard Sharpe <realrichardsharpe@...il.com>,
	Christoph Hellwig <hch@....de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Hannes Reinecke <hare@...e.de>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH v3] scsi_debug: Convert to use root_device_register() and
 root_device_unregister()

On Mon, Sep 06, 2010 at 11:00:56PM -0400, James Bottomley wrote:
> On Mon, 2010-09-06 at 17:32 -0700, Dmitry Torokhov wrote:
> > On Mon, Sep 06, 2010 at 05:24:28PM -0700, Nicholas A. Bellinger wrote:
> > > From: Nicholas Bellinger <nab@...ux-iscsi.org>
> > > 
> > > Hi Doug and Co,
> > > 
> > > This patch updates the scsi_debug virtual LLD to use root_device_register()
> > > and root_device_unregister() from include/linux/device.h instead of device_register()
> > > and device_unregister() respectively within scsi_debug_init() and scsi_debug_exit()
> > > This simply involved converting the static struct device pseudo_primary into a
> > > pointer that is setup by the call to root_device_register().
> > > 
> > > This patch also contains the correct IS_ERR() conditional check of
> > > root_device_register() from within scsi_debug_init().
> > > 
> > > Thanks to Richard Sharpe and Dmitry Torokhov for their help with this item.
> > > 
> > > Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
> > 
> > Thanks for making the changes.
> > 
> > Acked-by: Dmitry Torokhov <dtor@...l.ru>
> 
> Can I make that Reviewed-by:? Acked-by is really just for maintainer
> patches which don't warrant a signoff.
> 

Sure, whatever suits better.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/