linux-kernel - Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000401cb4e42$0c7b5b10$66f8800a@maildom.okisemi.com>
Date:	Tue, 7 Sep 2010 13:06:15 +0900
From:	"Masayuki Ohtake" <masa-korg@....okisemi.com>
To:	"FUJITA Tomonori" <fujita.tomonori@....ntt.co.jp>
Cc:	<fujita.tomonori@....ntt.co.jp>, <shemminger@...tta.com>,
	<sam@...nborg.org>, <joe@...ches.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<gregory.v.rose@...el.com>, <mbizon@...ebox.fr>,
	<kristoffer@...sler.com>, <ralf@...ux-mips.org>,
	<john.linn@...inx.com>, <randy.dunlap@...cle.com>,
	<davem@...emloft.net>, <meego-dev@...go.com>, <qi.wang@...el.com>,
	<yong.y.wang@...el.com>, <andrew.chih.howe.khor@...el.com>,
	<joel.clark@...el.com>, <margie.foster@...el.com>,
	<okada533@....okisemi.com>, <morinaga526@....okisemi.com>,
	<shimizu394@....okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

Hi Fujita

> > This DMA of device is not standard.  Personal use of Gigabit Ethernet device.
> > So, I guess that I do not need to use DMA-API.
>
> Sorry, I'm not sure what you mean. If a driver does DMA, it must use
> the DMA API. Your driver already uses the DMA API (pci_dma_*),
> however, pci_map_* API is obsolete so please use dma_map_* API
> instead.

Thank you for the explanation.
I understood and use dma_map_* .

Thanks Ohtake
----- Original Message ----- 
From: "FUJITA Tomonori" <fujita.tomonori@....ntt.co.jp>
To: <masa-korg@....okisemi.com>
Cc: <fujita.tomonori@....ntt.co.jp>; <shemminger@...tta.com>; <sam@...nborg.org>; <joe@...ches.com>;
<linux-kernel@...r.kernel.org>; <netdev@...r.kernel.org>; <gregory.v.rose@...el.com>; <mbizon@...ebox.fr>;
<kristoffer@...sler.com>; <ralf@...ux-mips.org>; <john.linn@...inx.com>; <randy.dunlap@...cle.com>;
<davem@...emloft.net>; <meego-dev@...go.com>; <qi.wang@...el.com>; <yong.y.wang@...el.com>;
<andrew.chih.howe.khor@...el.com>; <joel.clark@...el.com>; <margie.foster@...el.com>; <okada533@....okisemi.com>;
<morinaga526@....okisemi.com>; <shimizu394@....okisemi.com>
Sent: Tuesday, September 07, 2010 12:21 PM
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH


> On Tue, 7 Sep 2010 10:13:22 +0900
> "Masayuki Ohtake" <masa-korg@....okisemi.com> wrote:
>
> > > Probably, this trick doesn't work because zero could be a valid DMA
> > > address on some architctures.
> > >
> >
> > The flag which shows mapped will be added.
> > And it is used instead of "if (buffer_info->dma) ".
>
> Sounds fine. That's what other drivers do.
>
>
> > > > + /*-- Set Buffer infomation --*/
> > > > + buffer_info->length = skb->len;
> > > > + buffer_info->dma =
> > > > +     pci_map_single(adapter->pdev, skb->data, buffer_info->length,
> > > > +    PCI_DMA_TODEVICE);
> > >
> > > Needs to handle mapping failure (dma_mapping_errro)?
> >
> > Error process will be added.
>
> Nice.
>
>
> > > Can you use dma_map_* API instead of pci_map_*? Please read:
> > >
> >
> > This DMA of device is not standard.  Personal use of Gigabit Ethernet device.
> > So, I guess that I do not need to use DMA-API.
>
> Sorry, I'm not sure what you mean. If a driver does DMA, it must use
> the DMA API. Your driver already uses the DMA API (pci_dma_*),
> however, pci_map_* API is obsolete so please use dma_map_* API
> instead.
>
> Thanks,
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/