linux-kernel - Re: [PATCH] identify firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1009081147070.26813@pobox.suse.cz>
Date:	Wed, 8 Sep 2010 11:47:35 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Rafi Rubin <rafi@...s.upenn.edu>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	micki@...rig.com, rydberg@...omail.se, chatty@...c.fr
Subject: Re: [PATCH] identify firmware version

On Tue, 7 Sep 2010, Jiri Slaby wrote:

> >>>> +
> >>>> +		ret = ntrig_version_string(&data[2], buf);
> >>>> +
> >>>> +		dev_info(&hdev->dev,
> >>>> +			 "Firmware version: %s (%02x%02x %02x%02x)\n",
> >>>> +			 buf, data[2], data[3], data[4], data[5]);
> >>>> +
> >>>> +		kfree(buff);
> >>
> >> In any case, this doesn't compile...
> >>
> >>>> +	}
> > 
> > Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using 
> > gcc-3.4 (I think).
> 
> This version is OK. In the previous one, there was
> char *buf;
> ...
> kfree(buff);

Dmitry, Jiri, thanks a lot for taking care reviewing the patch while I 
have been lagging behind.

Now applied, thanks Rafi.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/