linux-kernel - Re: [PATCH 19/27] KVM: X86: Propagate fetch faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100908091802.GJ2177@amd.com>
Date:	Wed, 8 Sep 2010 11:18:03 +0200
From:	"Roedel, Joerg" <Joerg.Roedel@....com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, Alexander Graf <agraf@...e.de>,
	"joro@...tes.org" <joro@...tes.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/27] KVM: X86: Propagate fetch faults

On Tue, Sep 07, 2010 at 02:43:16PM -0400, Marcelo Tosatti wrote:
> On Mon, Sep 06, 2010 at 05:55:58PM +0200, Joerg Roedel wrote:
> >  		r = x86_decode_insn(&vcpu->arch.emulate_ctxt);
> > +		if (r == X86EMUL_PROPAGATE_FAULT)
> > +			goto done;
> > +
> 
> x86_decode_insn returns -1 / 0 ?

Yes. This looks like a left-over from v2 of the patch-set. I'll check
the path again and remove it if not necessary anymore.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/